SteNicholas edited a comment on issue #1136: [MINOR]Optimize hudi-cli module
URL: https://github.com/apache/incubator-hudi/pull/1136#issuecomment-568942473
 
 
   > `hudi-cli` as it is is weak on unit tests.. Do you want to first take up 
that task on the current master branch.. that way we would know how/if large 
changes like these affect the functionality..
   > 
   > Your changes may be fine. but I am just saying it would be good to first 
add some tests to the module.. (again not a problem of this PR, but something 
that affects it)
   
   @vinothchandar I optimize code of hudi-cli by intellij idea smart tips, 
never modify the original implement logic. Therefore this modification never 
need unit tests to prove the optimization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to