bvaradar commented on a change in pull request #1128: [HUDI-453] Fix throw
failed to archive commits error when writing data to MOR/COW table
URL: https://github.com/apache/incubator-hudi/pull/1128#discussion_r361775662
##########
File path:
hudi-client/src/main/java/org/apache/hudi/io/HoodieCommitArchiveLog.java
##########
@@ -316,9 +317,11 @@ private IndexedRecord convertToAvroRecord(HoodieTimeline
commitTimeline, HoodieI
break;
}
case HoodieTimeline.DELTA_COMMIT_ACTION: {
- HoodieCommitMetadata commitMetadata = HoodieCommitMetadata
- .fromBytes(commitTimeline.getInstantDetails(hoodieInstant).get(),
HoodieCommitMetadata.class);
-
archivedMetaWrapper.setHoodieCommitMetadata(commitMetadataConverter(commitMetadata));
+ if (HoodieInstant.State.REQUESTED != hoodieInstant.getState()) {
Review comment:
For COW tables, you need to do the similar steps for COMMIT_ACTION.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
