lamber-ken commented on issue #1128: [HUDI-453] Fix throw failed to archive commits error when writing data to MOR/COW table URL: https://github.com/apache/incubator-hudi/pull/1128#issuecomment-569474638 > @lamber-ken : there is a bug in HoodieActiveTimeline.saveToCleanRequested(). It was never meant to be empty. The cleaner plan needs to be stored in requested file in the timeline > > Remove these 2 lines > > * // Plan is only stored in auxiliary folder > * createFileInMetaPath(instant.getFileName(), Option.empty(), false); > and add > > * createFileInMetaPath(instant.getFileName(), content, false); > > This should guarantee that requested clean file is non-empty and no longer need any special casing in archiving. Done. I think it's a logic error, unit tests should not cover it, WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
