zhedoubushishi commented on a change in pull request #1175: [HUDI-495] Update
deprecated HBase API
URL: https://github.com/apache/incubator-hudi/pull/1175#discussion_r362999490
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/hbase/HBaseIndex.java
##########
@@ -287,13 +289,10 @@ private boolean checkIfValidCommit(HoodieTableMetaClient
metaClient, String comm
hbaseConnection = getHBaseConnection();
}
}
- HTable hTable = null;
- try {
- hTable = (HTable)
hbaseConnection.getTable(TableName.valueOf(tableName));
+ try (BufferedMutator mutator =
hbaseConnection.getBufferedMutator(TableName.valueOf(tableName))) {
Review comment:
Sure. Here is the doc:
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html.
```
The try-with-resources statement is a try statement that declares one or
more resources.
A resource is an object that must be closed after the program is finished
with it.
The try-with-resources statement ensures that each resource is closed at the
end of the statement.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
