n3nash commented on a change in pull request #1175: [HUDI-495] Update
deprecated HBase API
URL: https://github.com/apache/incubator-hudi/pull/1175#discussion_r363548127
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/hbase/HBaseIndex.java
##########
@@ -287,13 +289,10 @@ private boolean checkIfValidCommit(HoodieTableMetaClient
metaClient, String comm
hbaseConnection = getHBaseConnection();
}
}
- HTable hTable = null;
- try {
- hTable = (HTable)
hbaseConnection.getTable(TableName.valueOf(tableName));
+ try (BufferedMutator mutator =
hbaseConnection.getBufferedMutator(TableName.valueOf(tableName))) {
Review comment:
Thanks for providing the link, so is the `BufferedMutator` from Hbase also
the preferred new methodology ? (The above link tells me that from the JDBC
driver changes are fair)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
