leesf commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r364648753
########## File path: hudi-common/src/main/java/org/apache/hudi/common/util/TimelineDiffHelper.java ########## @@ -64,8 +64,7 @@ public static TimelineDiffResult getNewInstantsForIncrementalSync(HoodieTimeline if (!lostPendingCompactions.isEmpty()) { // If a compaction is unscheduled, fall back to complete refresh of fs view since some log files could have been // moved. Its unsafe to incrementally sync in that case. - LOG.warn("Some pending compactions are no longer in new timeline (unscheduled ?). They are :" - + lostPendingCompactions); + LOG.warn("Some pending compactions are no longer in new timeline (unscheduled ?). They are :{}", lostPendingCompactions); Review comment: ditto ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services