leesf commented on issue #1161: [HUDI-457]Redo hudi-common log statements using SLF4J URL: https://github.com/apache/incubator-hudi/pull/1161#issuecomment-572872998 > > Thanks for opening this PR @sev7e0 ! Looks good overall, only left some minor comments. > > Thanks for your review @leesf ! I'm thinking we need reduce our verification rules about `LineLength` in checkstyle. Now is `<property name="max" value="200"/>`, how about 130? 200 is decided when introducing spotless plugin, It should play well with currently checkstyle, after bringing back the spotless plugin, let's evaluate it again. And currently keep it as is would be better.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
