leesf commented on issue #1208: [HUDI-304] Bring back spotless plugin URL: https://github.com/apache/incubator-hudi/pull/1208#issuecomment-573490929 > Could you comment on the state of code formatting, if the PR is merged? Specifically > > * are all checkstyle error "fully" auto fixable using spotless or there are exceptions? > * are developers supposed to use the eclipse-java-google-style for formatting code or use checkstyle rules? > * what about intellij? > * can we update the contributing guide accordingly * Not all error would be fixed such as import order, but as we have ignore the import order rule, so it plays well with other rules. * Users would still use checkstyle rules of checkstyle.xml, and the introduced eclipse-java-google-style.xml is compatible with the rules of check.xml. * idea set up would still refer to (https://hudi.incubator.apache.org/newsite-content/contributing). * Yes, we would document how to fix code format error by using `mvn spotless:apply`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
