leesf commented on issue #1208: [HUDI-304] Bring back spotless plugin URL: https://github.com/apache/incubator-hudi/pull/1208#issuecomment-574102314 > > ocument that developers could use checkstyle.xml file in style folder in checkstyle plugin and things will go well > > I was able to use checkstyle to format in IntelliJ. This is fine.. but we should clearly document this. maybe file a JIRA? > > On import order, we can take a second stab may be down the line? again filing a JIRA would be great for tracking.. > > On this PR, my concern was we are reformatting again due to the 120 character limit? I was trying to see if we can avoid it. @leesf could you explain why 100+ files are being touched in this PR? If these were all checkstyle failures, then master would be broken right? I am just trying to understand what code really changed here, given we are close to a release.. Created https://issues.apache.org/jira/projects/HUDI/issues/HUDI-533 and https://issues.apache.org/jira/projects/HUDI/issues/HUDI-534 to track these. The changes in this PR has nothing to do with 120 character limit. And I randomly checked some modified files, they are modified after first introduced spotless plugin at 2019/10/10. The master won't broken as this PR is rebased to master branch. PS: And my another question is that if we need to modify `checkstyle-suppressions.xml` to make Reformat in IntelliJ, checkstyle.xml and eclipse-java-google-style.xml all pass? cc @bvaradar @vinothchandar
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
