YannByron commented on a change in pull request #4083:
URL: https://github.com/apache/hudi/pull/4083#discussion_r786714824



##########
File path: 
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/catalyst/catalog/HoodieCatalogTable.scala
##########
@@ -171,9 +175,14 @@ class HoodieCatalogTable(val spark: SparkSession, val 
table: CatalogTable) exten
         
.setTableCreateSchema(SchemaConverters.toAvroType(finalSchema).toString())
         .initTable(hadoopConf, tableLocation)
     } else {
+      val hoodieDatabaseName = if (hoodieTableExists) databaseName else
+        formatName(spark, 
table.identifier.database.getOrElse(spark.sessionState.catalog.getCurrentDatabase))
+      val hoodieTableName = if (hoodieTableExists) tableName else 
table.identifier.table

Review comment:
       here you don't need to judge `hoodieTableExists` is true or not. it must 
be false.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to