xushiyan commented on a change in pull request #3893:
URL: https://github.com/apache/hudi/pull/3893#discussion_r790191646
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/index/FlinkHoodieIndex.java
##########
@@ -48,22 +47,22 @@ protected FlinkHoodieIndex(HoodieWriteConfig config) {
@PublicAPIMethod(maturity = ApiMaturityLevel.DEPRECATED)
public abstract List<WriteStatus> updateLocation(List<WriteStatus>
writeStatuses,
HoodieEngineContext context,
- HoodieTable<T,
List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> hoodieTable) throws
HoodieIndexException;
+ HoodieTable hoodieTable)
throws HoodieIndexException;
@Override
@Deprecated
@PublicAPIMethod(maturity = ApiMaturityLevel.DEPRECATED)
public abstract List<HoodieRecord<T>> tagLocation(List<HoodieRecord<T>>
records,
HoodieEngineContext
context,
- HoodieTable<T,
List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatus>> hoodieTable) throws
HoodieIndexException;
+ HoodieTable hoodieTable)
throws HoodieIndexException;
@Override
@PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING)
public <R> HoodieData<HoodieRecord<R>> tagLocation(
HoodieData<HoodieRecord<R>> records, HoodieEngineContext context,
HoodieTable hoodieTable) throws HoodieIndexException {
- return HoodieList.of(tagLocation(
- HoodieList.getList(records.map(record -> (HoodieRecord<T>) record)),
context, hoodieTable));
+ List<HoodieRecord<T>> hoodieRecords =
tagLocation(HoodieList.getList(records.map(record -> (HoodieRecord<T>)
record)), context, hoodieTable);
+ return HoodieList.of(hoodieRecords.stream().map(r -> (HoodieRecord<R>)
r).collect(Collectors.toList()));
}
Review comment:
@yihua don't seem to find a better way than this double casting.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/BaseHoodieBloomIndexHelper.java
##########
@@ -51,7 +51,7 @@
public abstract HoodiePairData<HoodieKey, HoodieRecordLocation>
findMatchingFilesForRecordKeys(
HoodieWriteConfig config, HoodieEngineContext context, HoodieTable
hoodieTable,
HoodiePairData<String, String> partitionRecordKeyPairs,
- HoodieData<ImmutablePair<String, HoodieKey>> fileComparisonPairs,
+ HoodieData<Pair<String, HoodieKey>> fileComparisonPairs,
Review comment:
hide implementation from public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
