yihua commented on a change in pull request #4680:
URL: https://github.com/apache/hudi/pull/4680#discussion_r793305258
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -458,7 +458,7 @@ protected static int
upgradeOrDowngradeTable(JavaSparkContext jsc, String basePa
.setLoadActiveTimelineOnLoad(false).setConsistencyGuardConfig(config.getConsistencyGuardConfig())
.setLayoutVersion(Option.of(new
TimelineLayoutVersion(config.getTimelineLayoutVersion()))).build();
try {
- new UpgradeDowngrade(metaClient, config, new
HoodieSparkEngineContext(jsc), SparkUpgradeDowngradeHelper.getInstance())
+ new Versioner(metaClient, config, new HoodieSparkEngineContext(jsc),
SparkUpgradeDowngradeHelper.getInstance())
Review comment:
Not a strong opinion. I see you renamed upgrade- and downgrade-related
classes. This isn't in the scope of the class renaming originally. If we agree
that the new names are better, we can keep them in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
