hmatu commented on issue #1280: [MINOR] Remove junit-dep dependency URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-578889066 > @hmatu Sorry I am still trying to understand this PR. From the pom.xml you shared above - https://github.com/stefanbirkner/system-rules/blob/system-rules-1.16.0/pom.xml it does seem like junit-dep is a compile time dependency. You also mentioned that this dependency is not used anywhere and so you are adding the exclusion. Did you see any build time warning or dependency conflicts in Hudi that caused you to raised this PR? Can you please clarify? > Although this is a simple change, there might be other unused dependencies from external libraries same like this case. We havent gone after them unless the jar size is bloating or there are conflicts etc. Thats why understanding your case would help us better to determine if others also need to be checked out. Thanks. When compile the project, always need download the latest `junit-dep` version. ``` <dependency> <groupId>junit</groupId> <artifactId>junit-dep</artifactId> <version>[4.9,)</version> </dependency> ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
