yanghua commented on issue #1280: [MINOR] Remove junit-dep dependency URL: https://github.com/apache/incubator-hudi/pull/1280#issuecomment-579053301 > After tracking the git history, the `<junit-dep.version>4.10</junit-dep.version>` was introduced via PR #846 . And the dependency was used in `hudi-cli/pom.xml`. Then, the dependency was removed via HUDI-159. These actions are both invoked by @vinothchandar . > > Regarding the exclusion, @hmatu can you share the result of `system-rules` via `mvn dependency:tree`? Thanks. @bhasudha IMO, we can accept this PR (without the added exclusion property). In the early time, Hudi clearly introduced `junit-dep` dependency, just like I mentioned before. However, the dependency has been clearly removed, so the line `<junit-dep.version>4.10</junit-dep.version>` belongs to the legacy line. We can remove it. About the added exclusion property, we can add it or not. Although as @hmatu said, it would always be downloaded. However, it does not matter. It did not cause the version conflict. IMO, the exclusion property is usually used to handle version conflict of the same dependency. Generally, we clearly introduce a specific-version dependency then exclude the transitive dependencies which are owned by other dependencies. If a transitive dependency is harmless, we do not need to explicitly exclude it. In short, I agree with cleaning `<junit-dep.version>4.10</junit-dep.version>` up. As for exclusion, I am open. I recommend not including this exclusion. WDYT? @bhasudha @hmatu
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
