alexeykudinkin commented on a change in pull request #4753:
URL: https://github.com/apache/hudi/pull/4753#discussion_r802191020
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java
##########
@@ -346,23 +344,21 @@ protected void postCommit(HoodieTable<T,
List<HoodieRecord<T>>, List<HoodieKey>,
@Override
public void commitCompaction(
String compactionInstantTime,
- List<WriteStatus> writeStatuses,
- Option<Map<String, String>> extraMetadata) throws IOException {
+ HoodieCommitMetadata metadata,
Review comment:
If we don't care about the generic let's mark it as wildcard instead of
using it as raw type: `HoodieCommitMetadata<?>`
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java
##########
@@ -391,16 +387,11 @@ public void completeCompaction(
}
@Override
- protected List<WriteStatus> compact(String compactionInstantTime, boolean
shouldComplete) {
+ protected HoodieWriteMetadata<List<WriteStatus>> compact(String
compactionInstantTime, boolean shouldComplete) {
// only used for metadata table, the compaction happens in single thread
- try {
- List<WriteStatus> writeStatuses =
- getHoodieTable().compact(context,
compactionInstantTime).getWriteStatuses();
- commitCompaction(compactionInstantTime, writeStatuses, Option.empty());
- return writeStatuses;
- } catch (IOException e) {
- throw new HoodieException("Error while compacting instant: " +
compactionInstantTime);
- }
+ HoodieWriteMetadata<List<WriteStatus>> compactionMetadata =
getHoodieTable().compact(context, compactionInstantTime);
+ commitCompaction(compactionInstantTime,
compactionMetadata.getCommitMetadata().get(), Option.empty());
Review comment:
I don't think this is going to work: `commitMetadata` isn't set at this
point yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
