alexeykudinkin commented on a change in pull request #4753:
URL: https://github.com/apache/hudi/pull/4753#discussion_r804037044
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/CompactionHoodiePathCommand.scala
##########
@@ -111,17 +110,13 @@ case class CompactionHoodiePathCommand(path: String,
}
}
- private def handlerResponse(writeResponse: JavaRDD[WriteStatus]): Unit = {
+ private def handlerResponse(metadata: HoodieCommitMetadata): Unit = {
Review comment:
Typo: `handle`
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java
##########
@@ -346,23 +344,21 @@ protected void postCommit(HoodieTable<T,
List<HoodieRecord<T>>, List<HoodieKey>,
@Override
public void commitCompaction(
String compactionInstantTime,
- List<WriteStatus> writeStatuses,
- Option<Map<String, String>> extraMetadata) throws IOException {
+ HoodieCommitMetadata metadata,
Review comment:
Caught up offline: my comment was misattributed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
