yanghua commented on a change in pull request #1285: [HUDI-562] Added a few
test cases for class org.apache.hudi.WriteStatus
URL: https://github.com/apache/incubator-hudi/pull/1285#discussion_r372289684
##########
File path: hudi-client/src/test/java/org/apache/hudi/TestWriteStatus.java
##########
@@ -37,6 +38,14 @@ public void testFailureFraction() {
assertTrue(status.getFailedRecords().size() > 0);
assertTrue(status.getFailedRecords().size() < 150); // 150 instead of 100,
to prevent flaky test
assertTrue(status.hasErrors());
+
+ assertFalse(status.hasGlobalError());
+ status.setGlobalError(t);
+ assertTrue(status.hasGlobalError());
+ assertEquals(status.getGlobalError(), t);
Review comment:
IMO, testing a pure getter/setter method of a field is not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
