yanghua commented on a change in pull request #1285: [HUDI-562] Added a few
test cases for class org.apache.hudi.WriteStatus
URL: https://github.com/apache/incubator-hudi/pull/1285#discussion_r372288365
##########
File path: hudi-client/src/test/java/org/apache/hudi/TestWriteStatus.java
##########
@@ -49,7 +58,18 @@ public void testSuccessRecordTracking() {
}
assertEquals(1000, status.getFailedRecords().size());
assertTrue(status.hasErrors());
+ assertEquals(status.getErrors().size(), 1);
assertTrue(status.getWrittenRecords().isEmpty());
assertEquals(2000, status.getTotalRecords());
+
+ status.setTotalRecords(1000);
+ assertEquals(status.getTotalRecords(), 1000);
+ }
+
+ @Test
+ public void testAdditional() {
Review comment:
This test method does not have any assert, why we need to have it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services