nsivabalan commented on a change in pull request #4681:
URL: https://github.com/apache/hudi/pull/4681#discussion_r803669587
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java
##########
@@ -288,6 +288,7 @@ private HoodieMetadataColumnStats
combineColumnStatsMetadatat(HoodieMetadataPayl
return this.columnStatMetadata;
}
+ // HoodieMetadataPayload is an internal payload. Hence not implementing
newer apis with Properties as last argument.
Review comment:
yeah. I can move it. just that for metadata table, we will always stick
to OverwriteWithLatestPayload and hence may not leverage the props sent over.
but makes sense to fix everywhere irrespective of whether its used or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
