nsivabalan commented on a change in pull request #4681:
URL: https://github.com/apache/hudi/pull/4681#discussion_r803973650
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/payload/AWSDmsAvroPayload.java
##########
@@ -68,12 +69,25 @@ public AWSDmsAvroPayload(Option<GenericRecord> record) {
return delete ? Option.empty() : Option.of(insertValue);
}
+ @Override
+ public Option<IndexedRecord> getInsertValue(Schema schema, Properties
properties) throws IOException {
+ IndexedRecord insertValue = super.getInsertValue(schema, properties).get();
+ return handleDeleteOperation(insertValue);
Review comment:
my bad. we can't do that. it goes into infinite loop and errors out w/
stack overflow. since we use super.getInsertValue() here, this calls method in
L 79 and that inturn calls this method. reverting the changes to ensure no
indefinite loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
