leesf commented on a change in pull request #1237: [HUDI-583] Code Cleanup,
remove redundant code, and other changes
URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373762549
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/bloom/filter/InternalDynamicBloomFilter.java
##########
@@ -217,12 +214,8 @@ public void readFields(DataInput in) throws IOException {
* Adds a new row to <i>this</i> dynamic Bloom filter.
*/
private void addRow() {
- org.apache.hadoop.util.bloom.BloomFilter[] tmp = new
org.apache.hadoop.util.bloom.BloomFilter[matrix.length + 1];
-
- for (int i = 0; i < matrix.length; i++) {
- tmp[i] = matrix[i];
- }
-
+ BloomFilter[] tmp = new BloomFilter[matrix.length + 1];
+ System.arraycopy(matrix, 0, tmp, 0, matrix.length);
tmp[tmp.length - 1] = new
org.apache.hadoop.util.bloom.BloomFilter(vectorSize, nbHash, hashType);
Review comment:
So org.apache.hadoop.util.bloom.BloomFilter could be also changed to
BloomFilter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
