smarthi commented on a change in pull request #1237: [HUDI-583] Code Cleanup,
remove redundant code, and other changes
URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r373764565
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java
##########
@@ -45,13 +45,13 @@
.put(HoodieTimeline.COMPACTION_ACTION,
HoodieTimeline.COMMIT_ACTION).build();
public static final Comparator<HoodieInstant> ACTION_COMPARATOR =
- Comparator.<HoodieInstant, String>comparing(instant ->
getComparableAction(instant.getAction()));
+ Comparator.comparing(instant ->
getComparableAction(instant.getAction()));
public static final Comparator<HoodieInstant> COMPARATOR =
Comparator.comparing(HoodieInstant::getTimestamp)
.thenComparing(ACTION_COMPARATOR).thenComparing(HoodieInstant::getState);
- public static final String getComparableAction(String action) {
- return COMPARABLE_ACTIONS.containsKey(action) ?
COMPARABLE_ACTIONS.get(action) : action;
+ public static String getComparableAction(String action) {
Review comment:
its redundant for static methods since they can't be overriden anyways,
right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
