yanghua commented on a change in pull request #1302: [HUDI-595] code cleanup,
refactoring code out of PR# 1159
URL: https://github.com/apache/incubator-hudi/pull/1302#discussion_r374126914
##########
File path: hudi-client/src/test/java/org/apache/hudi/TestCleaner.java
##########
@@ -1079,19 +1081,17 @@ private void testPendingCompactions(HoodieWriteConfig
config, int expNumFilesDel
});
// Test for progress (Did we clean some files ?)
- long numFilesUnderCompactionDeleted =
hoodieCleanStats.stream().flatMap(cleanStat -> {
- return convertPathToFileIdWithCommitTime(newMetaClient,
cleanStat.getDeletePathPatterns())
- .map(fileIdWithCommitTime -> {
- if
(expFileIdToPendingCompaction.containsKey(fileIdWithCommitTime.getKey())) {
- Assert.assertTrue("Deleted instant time must be less than
pending compaction",
- HoodieTimeline.compareTimestamps(
-
fileIdToLatestInstantBeforeCompaction.get(fileIdWithCommitTime.getKey()),
- fileIdWithCommitTime.getValue(),
HoodieTimeline.GREATER));
- return true;
- }
- return false;
- });
- }).filter(x -> x).count();
+ long numFilesUnderCompactionDeleted =
hoodieCleanStats.stream().flatMap(cleanStat ->
convertPathToFileIdWithCommitTime(newMetaClient,
cleanStat.getDeletePathPatterns())
Review comment:
This line is too long, can we move something to the new line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
