yanghua commented on a change in pull request #1302: [HUDI-595] code cleanup, refactoring code out of PR# 1159 URL: https://github.com/apache/incubator-hudi/pull/1302#discussion_r374678425
########## File path: hudi-hadoop-mr/src/test/java/org/apache/hudi/hadoop/realtime/TestHoodieRealtimeRecordReader.java ########## @@ -491,7 +491,6 @@ public void testSchemaEvolutionAndRollbackBlockInLastLogFile() throws Exception writer = writeRollbackBlockToLogFile(partitionDir, schema, "fileid0", commitTime, newCommitTime, "101", 1); logFilePaths.add(writer.getLogFile().getPath().toString()); writer.close(); - assertTrue("block - size should be > 0", size > 0); Review comment: Intellij IDEA shows that the size is always larger than 0, so the assertion is always true. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services