xushiyan commented on a change in pull request #4811:
URL: https://github.com/apache/hudi/pull/4811#discussion_r810706251
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -257,6 +257,7 @@ private HoodieWriteConfig
createMetadataWriteConfig(HoodieWriteConfig writeConfi
// we will trigger compaction manually, to control the instant
times
.withInlineCompaction(false)
.withMaxNumDeltaCommitsBeforeCompaction(writeConfig.getMetadataCompactDeltaCommitMax())
+ .withPreserveCommitMetadata(false)
Review comment:
can you help me understand why we have to set false for metadata writer?
if possible, we should keep the compaction logic consistent everywhere. If
compaction is **defined as** not to alter commit time and such, then we better
not to have special cases for easy maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
