nsivabalan commented on a change in pull request #4811:
URL: https://github.com/apache/hudi/pull/4811#discussion_r811098250
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
##########
@@ -294,6 +294,8 @@ protected boolean writeRecord(HoodieRecord<T> hoodieRecord,
Option<IndexedRecord
// Convert GenericRecord to GenericRecord with hoodie commit metadata
in schema
IndexedRecord recordWithMetadataInSchema =
rewriteRecord((GenericRecord) indexedRecord.get());
if (preserveMetadata) {
+ // do not preserve FILENAME_METADATA_FIELD
Review comment:
yes. so by preserve commit metadata, implicitly we mean to preserve
every commit metadata except filename. Every other meta field should be carry
forwarded from old record, but filename has to represent the file where the
record actually exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
