xushiyan commented on pull request #4880:
URL: https://github.com/apache/hudi/pull/4880#issuecomment-1051004286


   > > @danny0405 i see. the main problem now is the new DeleteKey breaks the 
serde with log block contains HoodieKey, correct? The compatibility issue is 
quite impactful. I noticed there is a version bit in reading the block `int 
version = dis.readInt()` in `getKeysToDelete()` which is not used. Now might it 
be make use of?
   > 
   > Don't know how to do that ? Can you give some help in a following PR, 
appreciate that if you can help with that.
   
   Only some rough thoughts: with the patch, starting to write the log block 
bytes with version = 2 and when deserialize, treat the bytes differently based 
on the version value got from first `readInt()`. Would be happy to help where I 
can. But let's confirm the overall fix with @vinothchandar before moving onto 
further low-level changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to