xushiyan commented on a change in pull request #4856:
URL: https://github.com/apache/hudi/pull/4856#discussion_r825482175
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -397,7 +398,7 @@ protected void rollbackFailedBootstrap() {
* @return Collection of WriteStatus to inspect errors and counts
*/
public abstract O bulkInsert(I records, final String instantTime,
- Option<BulkInsertPartitioner<I>>
userDefinedBulkInsertPartitioner);
+ Option<BulkInsertPartitioner<?>>
userDefinedBulkInsertPartitioner);
Review comment:
@yihua yes this was noted down in
https://issues.apache.org/jira/browse/HUDI-3463
basically we're assuming `I` as JavaRDD from the beginning. Changing this
affects user-defined classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
