xushiyan commented on a change in pull request #4856:
URL: https://github.com/apache/hudi/pull/4856#discussion_r825521470
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java
##########
@@ -224,44 +232,50 @@ public HoodieWriteResult
insertOverwriteTable(JavaRDD<HoodieRecord<T>> records,
}
@Override
- public JavaRDD<WriteStatus> bulkInsert(JavaRDD<HoodieRecord<T>> records,
String instantTime, Option<BulkInsertPartitioner<JavaRDD<HoodieRecord<T>>>>
userDefinedBulkInsertPartitioner) {
- HoodieTable<T, JavaRDD<HoodieRecord<T>>, JavaRDD<HoodieKey>,
JavaRDD<WriteStatus>> table =
+ public JavaRDD<WriteStatus> bulkInsert(JavaRDD<HoodieRecord<T>> records,
String instantTime, Option<BulkInsertPartitioner<?>>
userDefinedBulkInsertPartitioner) {
+ HoodieTable<T, HoodieData<HoodieRecord<T>>, HoodieData<HoodieKey>,
HoodieData<WriteStatus>> table =
initTable(WriteOperationType.BULK_INSERT,
Option.ofNullable(instantTime));
table.validateInsertSchema();
preWrite(instantTime, WriteOperationType.BULK_INSERT,
table.getMetaClient());
- HoodieWriteMetadata<JavaRDD<WriteStatus>> result =
table.bulkInsert(context,instantTime, records,
userDefinedBulkInsertPartitioner);
- return postWrite(result, instantTime, table);
+ Option<BulkInsertPartitioner<?>> partitionerOption =
Option.ofNullable(userDefinedBulkInsertPartitioner.orElse(null));
+ HoodieWriteMetadata<HoodieData<WriteStatus>> result =
table.bulkInsert(context,instantTime, HoodieJavaRDD.of(records),
partitionerOption);
+ HoodieWriteMetadata<JavaRDD<WriteStatus>> resultRDD =
result.clone(HoodieJavaRDD.getJavaRDD(result.getWriteStatuses()));
+ return postWrite(resultRDD, instantTime, table);
}
@Override
- public JavaRDD<WriteStatus>
bulkInsertPreppedRecords(JavaRDD<HoodieRecord<T>> preppedRecords, String
instantTime, Option<BulkInsertPartitioner<JavaRDD<HoodieRecord<T>>>>
bulkInsertPartitioner) {
- HoodieTable<T, JavaRDD<HoodieRecord<T>>, JavaRDD<HoodieKey>,
JavaRDD<WriteStatus>> table =
+ public JavaRDD<WriteStatus>
bulkInsertPreppedRecords(JavaRDD<HoodieRecord<T>> preppedRecords, String
instantTime, Option<BulkInsertPartitioner<?>> bulkInsertPartitioner) {
+ HoodieTable<T, HoodieData<HoodieRecord<T>>, HoodieData<HoodieKey>,
HoodieData<WriteStatus>> table =
initTable(WriteOperationType.BULK_INSERT_PREPPED,
Option.ofNullable(instantTime));
table.validateInsertSchema();
preWrite(instantTime, WriteOperationType.BULK_INSERT_PREPPED,
table.getMetaClient());
- HoodieWriteMetadata<JavaRDD<WriteStatus>> result =
table.bulkInsertPrepped(context,instantTime, preppedRecords,
bulkInsertPartitioner);
- return postWrite(result, instantTime, table);
+ Option<BulkInsertPartitioner<?>> partitionerOption =
Option.ofNullable(bulkInsertPartitioner.orElse(null));
Review comment:
gonna remove `<?>` from the usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
