yanghua commented on a change in pull request #1344: [HUDI-624]: Split some of
the code from PR for HUDI-479
URL: https://github.com/apache/incubator-hudi/pull/1344#discussion_r382364978
##########
File path: hudi-hive/src/main/java/org/apache/hudi/hive/SchemaDifference.java
##########
@@ -74,6 +67,17 @@ public boolean isEmpty() {
return deleteColumns.isEmpty() && updateColumnTypes.isEmpty() &&
addColumnTypes.isEmpty();
}
+ @Override
+ public String toString() {
+ return new StringJoiner(", ", SchemaDifference.class.getSimpleName() +
"[", "]")
Review comment:
It seems that we have changed the generated string pattern? Did you check
whether the `SchemaDifference#toString` method is used in the key judgement
logic or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
