yanghua commented on a change in pull request #1344: [HUDI-624]: Split some of the code from PR for HUDI-479 URL: https://github.com/apache/incubator-hudi/pull/1344#discussion_r382364125
########## File path: hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java ########## @@ -16,24 +16,23 @@ package org.apache.hudi.common.util; -import com.google.common.base.Preconditions; -import com.google.common.cache.CacheBuilder; -import com.google.common.cache.CacheLoader; -import com.google.common.cache.LoadingCache; -import com.google.common.collect.Sets; - import java.lang.management.ManagementFactory; import java.lang.management.MemoryPoolMXBean; import java.lang.reflect.Array; import java.lang.reflect.Field; import java.lang.reflect.Modifier; import java.util.ArrayDeque; import java.util.Arrays; +import java.util.Collections; import java.util.Deque; +import java.util.IdentityHashMap; import java.util.LinkedList; import java.util.List; +import java.util.Map; +import java.util.Objects; import java.util.Set; + Review comment: redundant empty line? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
