yihua commented on a change in pull request #5149:
URL: https://github.com/apache/hudi/pull/5149#discussion_r836643753
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
##########
@@ -556,7 +570,9 @@ private static void
processRollbackMetadata(HoodieActiveTimeline metadataTableTi
//
// when at time t4, we commit the compaction rollback,the above check
returns true.
HoodieInstant syncedInstant = new HoodieInstant(false,
HoodieTimeline.DELTA_COMMIT_ACTION, instantToRollback);
- if
(metadataTableTimeline.getCommitsTimeline().isBeforeTimelineStarts(syncedInstant.getTimestamp()))
{
+ Option<HoodieInstant> firstInstant =
metadataTableTimeline.getCommitsTimeline().firstInstant();
Review comment:
Right. I actually thought about that, but that requires more changes
and touches the archived timeline as well. Let's keep the scope of this PR and
fix that archival-related case later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
