nsivabalan commented on a change in pull request #5149:
URL: https://github.com/apache/hudi/pull/5149#discussion_r836710264
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
##########
@@ -556,7 +570,9 @@ private static void
processRollbackMetadata(HoodieActiveTimeline metadataTableTi
//
// when at time t4, we commit the compaction rollback,the above check
returns true.
HoodieInstant syncedInstant = new HoodieInstant(false,
HoodieTimeline.DELTA_COMMIT_ACTION, instantToRollback);
- if
(metadataTableTimeline.getCommitsTimeline().isBeforeTimelineStarts(syncedInstant.getTimestamp()))
{
+ Option<HoodieInstant> firstInstant =
metadataTableTimeline.getCommitsTimeline().firstInstant();
Review comment:
while I appreciate the intent here, but if there are gaps anyways, I
would like to see whats the path here. It would be easier(easy for end user to
understand the limitations) to call out if we don't fix this at all. But if we
fix only partially, then explaining the limitation will be hard.
One thing we could do is, in the restore code path, we put in a check if
this condition is met, and if yes, we can even delete the entire MDT table and
proceed w/ restore. The first commit after restore, will trigger the
initialization of entire MDT again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
