alexeykudinkin commented on code in PR #5296:
URL: https://github.com/apache/hudi/pull/5296#discussion_r849932758
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java:
##########
@@ -370,6 +360,16 @@ public void write(GenericRecord oldRecord) {
}
}
+ protected void writeToFile(HoodieKey key, GenericRecord avroRecord, boolean
shouldPreserveRecordMetadata) throws IOException {
+ if (shouldPreserveRecordMetadata) {
+ // NOTE: `FILENAME_METADATA_FIELD` has to be rewritten to correctly
point to the
Review Comment:
Totally. Previously it relied on `preserveMetadata` fields which were not
available in `CreateHandle`, so had to bail on moving it to `WriteHandle`
class, but then after refactoring forgot to update `CreateHandle`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
