YuweiXiao commented on code in PR #4441:
URL: https://github.com/apache/hudi/pull/4441#discussion_r857056059
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/commit/JavaBulkInsertHelper.java:
##########
@@ -77,8 +77,12 @@ public HoodieWriteMetadata<List<WriteStatus>>
bulkInsert(final List<HoodieRecord
config.shouldAllowMultiWriteOnSameInstant());
}
+ BulkInsertPartitioner partitioner =
userDefinedBulkInsertPartitioner.isPresent()
+ ? userDefinedBulkInsertPartitioner.get()
+ :
JavaBulkInsertInternalPartitionerFactory.get(config.getBulkInsertSortMode());
+
// write new files
- List<WriteStatus> writeStatuses = bulkInsert(inputRecords, instantTime,
table, config, performDedupe, userDefinedBulkInsertPartitioner, false,
config.getBulkInsertShuffleParallelism(), new CreateHandleFactory(false));
+ List<WriteStatus> writeStatuses = bulkInsert(inputRecords, instantTime,
table, config, performDedupe, partitioner, false,
config.getBulkInsertShuffleParallelism(), new CreateHandleFactory(false));
Review Comment:
Got it, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
