YuweiXiao commented on code in PR #4441:
URL: https://github.com/apache/hudi/pull/4441#discussion_r857056202
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkBulkInsertHelper.java:
##########
@@ -76,9 +73,14 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>>
bulkInsert(final HoodieData<
table.getActiveTimeline().transitionRequestedToInflight(new
HoodieInstant(HoodieInstant.State.REQUESTED,
executor.getCommitActionType(), instantTime), Option.empty(),
config.shouldAllowMultiWriteOnSameInstant());
+
+ BulkInsertPartitioner partitioner =
userDefinedBulkInsertPartitioner.isPresent()
Review Comment:
The BulkInsertPartitionerFactory is different for spark&java. I could
extract an interface(e.g., GetBulkInsertPartitionerFactory) to the base class
if we want to unify the code. But as yihua said, the change of public interface
may broken existing users' code, requiring them to update their code too.
ps. I have re-written this part of the code to make it more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
