jinxing64 commented on code in PR #5534:
URL: https://github.com/apache/hudi/pull/5534#discussion_r867670047
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala:
##########
@@ -81,13 +81,13 @@ class TestAlterTableDropPartition extends
HoodieSparkSqlTestBase {
}
Seq(false, true).foreach { urlencode =>
- test(s"Drop single-partition table' partitions, urlencode: $urlencode") {
+ test(s"Drop single-partition table's partitions, urlencode: $urlencode") {
withTempDir { tmp =>
val tableName = generateTableName
val tablePath = s"${tmp.getCanonicalPath}/$tableName"
import spark.implicits._
Review Comment:
It makes no sense to config urlencode=false when partition value contains
slash -- '/' , it brings much obstacles when parsing partition values from path
-- running 'show partitions' fails easily in scenarios. I replace "/" with "#",
which triggers character escaping but doesn't break partition path parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
