smarthi commented on a change in pull request #1350: [HUDI-629]: Replace
Guava's Hashing with an equivalent in NumericUtils.java
URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392151737
##########
File path:
hudi-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
##########
@@ -144,7 +144,12 @@ public int numPartitions() {
@Override
public int getPartition(Object key) {
final Pair<String, String> parts = (Pair<String, String>) key;
- final long hashOfKey = Hashing.md5().hashString(parts.getRight(),
StandardCharsets.UTF_8).asLong();
+ long hashOfKey = 0L;
Review comment:
replaced with SHA-256 - but got'ta test it out on long strings to see how it
works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
