cuibo01 commented on code in PR #5545:
URL: https://github.com/apache/hudi/pull/5545#discussion_r869830519
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -644,14 +644,17 @@ public final Stream<FileSlice>
getLatestUnCompactedFileSlices(String partitionSt
@Override
public final Stream<FileSlice> getLatestFileSlicesBeforeOrOn(String
partitionStr, String maxCommitTime,
- boolean includeFileSlicesInPendingCompaction) {
+ boolean includeFileSlicesInPendingCompaction, boolean
includeFilesInPendingCompaction) {
try {
readLock.lock();
String partitionPath = formatPartitionKey(partitionStr);
ensurePartitionLoadedCorrectly(partitionPath);
Stream<FileSlice> fileSliceStream =
fetchLatestFileSlicesBeforeOrOn(partitionPath, maxCommitTime)
.filter(slice ->
!isFileGroupReplacedBeforeOrOn(slice.getFileGroupId(), maxCommitTime));
if (includeFileSlicesInPendingCompaction) {
+ if (includeFilesInPendingCompaction) {
+ return fileSliceStream.map(this::addBootstrapBaseFileIfPresent);
Review Comment:
When job is restarted, compaction operator and bootstrap operator are
initialized at the same time. The bootstrapOperator#initializeState is executed
before the compactionOperator#open. So bootstrapOperator#loadRecords may have
got the wrong fileSlices, the logic
(https://github.com/apache/hudi/blob/4258a715174e0a97271112148ab20ef9307e2bd8/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java#L416)
filters out pendingCompaction files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
