cuibo01 commented on code in PR #5545:
URL: https://github.com/apache/hudi/pull/5545#discussion_r869859141
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -644,14 +644,17 @@ public final Stream<FileSlice>
getLatestUnCompactedFileSlices(String partitionSt
@Override
public final Stream<FileSlice> getLatestFileSlicesBeforeOrOn(String
partitionStr, String maxCommitTime,
- boolean includeFileSlicesInPendingCompaction) {
+ boolean includeFileSlicesInPendingCompaction, boolean
includeFilesInPendingCompaction) {
try {
readLock.lock();
String partitionPath = formatPartitionKey(partitionStr);
ensurePartitionLoadedCorrectly(partitionPath);
Stream<FileSlice> fileSliceStream =
fetchLatestFileSlicesBeforeOrOn(partitionPath, maxCommitTime)
.filter(slice ->
!isFileGroupReplacedBeforeOrOn(slice.getFileGroupId(), maxCommitTime));
if (includeFileSlicesInPendingCompaction) {
+ if (includeFilesInPendingCompaction) {
+ return fileSliceStream.map(this::addBootstrapBaseFileIfPresent);
Review Comment:
but from log，pendingCompaction contains not only logs, but also parquet
file(02d71f2b-bb2f-4c44-96f2-78cb791da28e_8-10-0_20220425131251.parquet), and
then the logic filters the parquet,
https://github.com/apache/hudi/blob/4258a715174e0a97271112148ab20ef9307e2bd8/hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java#L422
so bootstrapOperator cannot obtain the data in the parquet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
