leesf commented on code in PR #5588:
URL: https://github.com/apache/hudi/pull/5588#discussion_r875466366
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -763,4 +763,22 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
assertResult(true)(shown.contains("COMMENT 'This is a simple hudi
table'"))
}
}
+
+ test("Test CTAS using an illegal definition -- a COW table with compaction
enabled.") {
+ val tableName = generateTableName
+ checkExceptionContain(
+ s"""
+ | create table $tableName using hudi
+ | tblproperties(
+ | primaryKey = 'id',
+ | type = 'cow',
+ | hoodie.compact.inline='true'
Review Comment:
sorry I do not see the check logic for the invalid definition in this PR, am
I missing it?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -763,4 +763,22 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
assertResult(true)(shown.contains("COMMENT 'This is a simple hudi
table'"))
}
}
+
+ test("Test CTAS using an illegal definition -- a COW table with compaction
enabled.") {
+ val tableName = generateTableName
+ checkExceptionContain(
+ s"""
+ | create table $tableName using hudi
+ | tblproperties(
+ | primaryKey = 'id',
+ | type = 'cow',
+ | hoodie.compact.inline='true'
Review Comment:
sorry I do not see the check logic for the invalid definition in this PR, am
I missing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
