jinxing64 commented on code in PR #5588:
URL: https://github.com/apache/hudi/pull/5588#discussion_r878689578
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -763,4 +763,22 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
assertResult(true)(shown.contains("COMMENT 'This is a simple hudi
table'"))
}
}
+
+ test("Test CTAS using an illegal definition -- a COW table with compaction
enabled.") {
+ val tableName = generateTableName
+ checkExceptionContain(
+ s"""
+ | create table $tableName using hudi
+ | tblproperties(
+ | primaryKey = 'id',
+ | type = 'cow',
+ | hoodie.compact.inline='true'
Review Comment:
I applied on "wechat" :)
Stacktrace as below:
```
org.apache.hudi.exception.HoodieNotSupportedException: Compaction is not
supported on a CopyOnWrite table
at
org.apache.hudi.table.HoodieSparkCopyOnWriteTable.scheduleCompaction(HoodieSparkCopyOnWriteTable.java:169)
at
org.apache.hudi.client.BaseHoodieWriteClient.scheduleTableServiceInternal(BaseHoodieWriteClient.java:1348)
at
org.apache.hudi.client.BaseHoodieWriteClient.scheduleTableService(BaseHoodieWriteClient.java:1325)
at
org.apache.hudi.client.BaseHoodieWriteClient.scheduleCompactionAtInstant(BaseHoodieWriteClient.java:1003)
at
org.apache.hudi.client.BaseHoodieWriteClient.scheduleCompaction(BaseHoodieWriteClient.java:994)
at
org.apache.hudi.client.BaseHoodieWriteClient.inlineScheduleCompaction(BaseHoodieWriteClient.java:1252)
at
org.apache.hudi.client.BaseHoodieWriteClient.inlineCompaction(BaseHoodieWriteClient.java:1238)
at
org.apache.hudi.client.BaseHoodieWriteClient.runTableServicesInline(BaseHoodieWriteClient.java:552)
at
org.apache.hudi.client.BaseHoodieWriteClient.commitStats(BaseHoodieWriteClient.java:245)
at
org.apache.hudi.client.SparkRDDWriteClient.commit(SparkRDDWriteClient.java:122)
at
org.apache.hudi.HoodieSparkSqlWriter$.commitAndPerformPostOperations(HoodieSparkSqlWriter.scala:651)
at
org.apache.hudi.HoodieSparkSqlWriter$.write(HoodieSparkSqlWriter.scala:315)
at org.apache.hudi.DefaultSource.createRelation(DefaultSource.scala:163)
at
org.apache.spark.sql.execution.datasources.SaveIntoDataSourceCommand.run(SaveIntoDataSourceCommand.scala:45)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
