Clcanny commented on code in PR #5709:
URL: https://github.com/apache/hudi/pull/5709#discussion_r884144348


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -122,6 +122,9 @@ public static Source createSource(String sourceClass, 
TypedProperties cfg, JavaS
                 HoodieDeltaStreamerMetrics.class},
             cfg, jssc, sparkSession, schemaProvider, metrics);
       } catch (HoodieException e) {
+        if (e.getCause() != null && !(e.getCause() instanceof 
NoSuchMethodException)) {
+          LOG.error("Could not load source class " + sourceClass, e);

Review Comment:
   Maybe some Source class just implement constructor of `(TypedProperties 
properties, JavaSparkContext sparkContext, SparkSession sparkSession, 
SchemaProvider schemaProvider)`, doesn't implement `(TypedProperties 
properties, JavaSparkContext sparkContext, SparkSession sparkSession, 
SchemaProvider schemaProvider, HoodieDeltaStreamerMetrics metrics)`.
   
   Then if we don't judge, there are a lot of error messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to