xushiyan commented on code in PR #5709:
URL: https://github.com/apache/hudi/pull/5709#discussion_r884162763
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -122,6 +122,9 @@ public static Source createSource(String sourceClass,
TypedProperties cfg, JavaS
HoodieDeltaStreamerMetrics.class},
cfg, jssc, sparkSession, schemaProvider, metrics);
} catch (HoodieException e) {
+ if (e.getCause() != null && !(e.getCause() instanceof
NoSuchMethodException)) {
+ LOG.error("Could not load source class " + sourceClass, e);
Review Comment:
@Clcanny this sort of logic is very unconventional. when there is an error,
we log it. that's simple and straightforward. if you find a lot of unwanted
logs, then put a fix on the root cause, instead of putting a band-aid fix like
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
