CTTY commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r888425889
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String
tableName, String ta
}
private static int rollback(JavaSparkContext jsc, String instantTime, String
basePath, Boolean rollbackUsingMarkers) throws Exception {
- SparkRDDWriteClient client = createHoodieClient(jsc, basePath,
rollbackUsingMarkers);
+ SparkRDDWriteClient client = createHoodieClient(jsc, basePath,
rollbackUsingMarkers, false);
Review Comment:
We can but adding a test is non-trival work, as it involves another option
introduced in this [PR](https://github.com/apache/hudi/pull/5158/files)
We might want to file a seperate jira to add a test.
Apart from that, I tested this fix manually on AWS EMR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
