yuzhaojing commented on code in PR #5681:
URL: https://github.com/apache/hudi/pull/5681#discussion_r909781246
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java:
##########
@@ -152,9 +156,26 @@ protected Option<HoodieCleanerPlan> requestClean(String
startCleanTime) {
LOG.error("Got exception when saving cleaner requested file", e);
throw new HoodieIOException(e.getMessage(), e);
}
- return Option.of(cleanerPlan);
+ option = Option.of(cleanerPlan);
}
- return Option.empty();
+
+ if (config.isTableManagerEnabled() &&
config.getTableManagerConfig().getTableManagerActions().contains(ActionType.clean.name()))
{
Review Comment:
This is a cleaner implementation, I will modify the implementation.
But I don't want to introduce a lock manager in the current version, it is
too heavy for the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
