yuzhaojing commented on code in PR #5681:
URL: https://github.com/apache/hudi/pull/5681#discussion_r909786382
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java:
##########
@@ -152,9 +156,26 @@ protected Option<HoodieCleanerPlan> requestClean(String
startCleanTime) {
LOG.error("Got exception when saving cleaner requested file", e);
throw new HoodieIOException(e.getMessage(), e);
}
- return Option.of(cleanerPlan);
+ option = Option.of(cleanerPlan);
}
- return Option.empty();
+
+ if (config.isTableManagerEnabled() &&
config.getTableManagerConfig().getTableManagerActions().contains(ActionType.clean.name()))
{
+ submitCleanToService();
+ }
+
+ return option;
+ }
+
+ private void submitCleanToService() {
+ HoodieTableMetaClient metaClient = table.getMetaClient();
+ List<String> instantsToSubmit = metaClient.getActiveTimeline()
Review Comment:
We plan to schedule plan and move execution to tms by writer in tms phase1,
and support schedule in tms in tms phase2. Because the current concurrency
control needs to introduce external dependencies, but we can reserve parameters
in the core api. WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
