xushiyan commented on code in PR #5627:
URL: https://github.com/apache/hudi/pull/5627#discussion_r913168791
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecord.java:
##########
@@ -131,25 +131,35 @@ public String getFieldName() {
*/
private HoodieOperation operation;
+ /**
+ * For purposes of preCombining.
+ */
+ private Comparable<?> orderingVal;
Review Comment:
we can work on renaming in a separate PR once we decided. We should
standardize names: precombineField (SQL), orderingVal (pojo),
--source-ordering-field (deltastreamer), and eventTimeField (default record
payload)
@wulei0302 do you want to take up this improvement/refactoring work? could
you file a ticket for tracking pls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
