xushiyan commented on code in PR #5627:
URL: https://github.com/apache/hudi/pull/5627#discussion_r913173208
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -95,6 +99,7 @@ protected HoodieMergedLogRecordScanner(FileSystem fs, String
basePath, List<Stri
this.records = new ExternalSpillableMap<>(maxMemorySizeInBytes,
spillableMapBasePath, new DefaultSizeEstimator(),
new HoodieRecordSizeEstimator(readerSchema), diskMapType,
isBitCaskDiskMapCompressionEnabled);
this.maxMemorySizeInBytes = maxMemorySizeInBytes;
+ this.merge = HoodieRecordUtils.loadMerge(getMergeClassFQN());
Review Comment:
throughout the codebase i've seen `FQCN`, and `className` being used. Here
is another variety (FQN). in step 3 you may change this to `className` which
appears most, for alignment. @wulei0302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
