yanghua commented on a change in pull request #1460: [HUDI-679] Make io package
Spark free
URL: https://github.com/apache/incubator-hudi/pull/1460#discussion_r399660338
##########
File path:
hudi-client/src/main/java/org/apache/hudi/execution/BulkInsertMapFunction.java
##########
@@ -51,6 +51,7 @@ public BulkInsertMapFunction(String instantTime,
HoodieWriteConfig config, Hoodi
@Override
public Iterator<List<WriteStatus>> call(Integer partition,
Iterator<HoodieRecord<T>> sortedRecordItr) {
return new CopyOnWriteLazyInsertIterable<>(sortedRecordItr, config,
instantTime, hoodieTable,
- fileIDPrefixes.get(partition));
+ fileIDPrefixes.get(partition), hoodieTable.getIdSupplier(),
hoodieTable.getStageSupplier(),
Review comment:
`hoodieTable.getIdSupplier()` is not clear here. I suggest we can rename
these getter to e.g. `getPartitionIdSupplier`, `getStageId` and `getAttemptId`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
